Helm: chart fixes and improvements #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crabique <crabique@users.noreply.github.com>
…tart pod upon SSH key change too Signed-off-by: crabique <crabique@users.noreply.github.com>
Signed-off-by: crabique <crabique@users.noreply.github.com>
Signed-off-by: crabique <crabique@users.noreply.github.com>
Signed-off-by: crabique <crabique@users.noreply.github.com>
|
Thanks for the merge! I didn't expect this to be tagged 0.12.5 as is 😄 This means the exporter image in the chart defaults of 0.12.5 is still 0.12.4, is this something expected? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Thanks for the great exporter, I was very glad to see it already had a Helm chart.
This PR includes some fixes and improvements that make it easier to use without forking or applying Kustomize patches.
ServiceMonitorextraVolumesandextraVolumeMounts:Deploymentannotations:Secretchangesvalues.yamlPlease let me know if you have any questions regarding any of the changes.