Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export interface speeds #39

Merged
merged 2 commits into from
Apr 28, 2019
Merged

export interface speeds #39

merged 2 commits into from
Apr 28, 2019

Conversation

qybl
Copy link
Contributor

@qybl qybl commented Apr 27, 2019

This PR exports interface speeds, the map consists of the speeds we have in our org but is not exhaustive, other than adding all possible speeds I can't think of a better idea to solve this.

This fixes #27

@czerwonk czerwonk merged commit 6f81c67 into czerwonk:master Apr 28, 2019
@qybl qybl deleted the interface-speed branch April 28, 2019 14:42
@bjornryden
Copy link
Contributor

Thanks for making this - it's very useful. I tried having a go at it myself, but fell a bit short in my go skills.

A few comments:

  • Would it be possible to regexp out the integer and the string instead? Aggregated interfaces, for example, can come with all weird capacities, such as "3Gbps".
  • Logical interfaces can also have the "bandwidth" setting which acts much in the same way as this, in regards to "number+string", however it becomes a "float+string", as setting bandwith to "1200" ends up as 1.200Kbps. This could be useful for some people, if they have services from ISPs that are capped in some way beyong the physical interface.

Personally, I really could use drawing both upload and download limits. For now I just use a silly txt-exporter for these values, as there's no way of setting asynchronous speed limits in the "bandwidth" section. I was thinking maybe it could be worth doing a regexp on the interface description, maybe even extracting labels automatically from this as well. Eg. "CircuitID=XXXXXXX;DL=1000;UL=100;CustomerID=YYYYYYY".

martintopholm pushed a commit to martintopholm/junos_exporter that referenced this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: interface speed
3 participants