fix: handle renamed dependencies correctly #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Could you add a test case for this issue? |
|
@d-e-s-o Hmm, I'm not sure how to add complex test, but this fixed my issue in this repo: https://github.com/StackOverflowExcept1on/cargo-bug |
|
I've encountered another issue with renamed dependencies in my workspace. It seems that cargo-http-registry doesn't support the latest changes https://github.com/rust-lang/cargo/blob/master/src/doc/src/reference/registry-index.md. It seems issue #61 occurs because |
|
Thanks! |
d-e-s-o
added a commit
that referenced
this pull request
Aug 15, 2024
Add a CHANGELOG entry for pull request #60, which fixed handling of renamed packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #59. See issue for more details. This PR fixes the handling of renamed dependencies (previously
bar = { version = "1.0", package = "foo" }was handled incorrectly). I also added .gitignore file.@d-e-s-o It would be nice to create release on crates.io right after this commit.