Undefined behavior fix on ticket.c #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack garbage is always a luck of the draw This was causing issues on non-LTO build. LTO was just lucky.
|
Fix to referenced crash here: #837 (comment) |
eku
reviewed
Jan 24, 2024
Wolfvak
approved these changes
Jan 25, 2024
MisterSheeple
pushed a commit
to MisterSheeple/DumpATron3D
that referenced
this pull request
Apr 19, 2024
Stack garbage is always a luck of the draw This was causing issues on non-LTO build. LTO was just lucky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack garbage is always a luck of the draw
This was causing issues on non-LTO build.
LTO was just lucky.
One bad pointer to rule them all.