-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
blocked until I did cluster tests |
@juliangieseke I added a commit with one of our required changes (that we merged today) :). |
The Cluster I ramped up with my initial state of this PR looks good. can someone else please pick up this PR? there also seems to be a merge conflict now :( |
actually, @hectorj2f why are these lines removed? AFAIK UI depends on them. cc @natmegs |
@juliangieseke I believe these were needed before for KCL to know which version of kubeaddons to use based on given k8s version. @hectorj2f is this now being defaulted in some other way? |
c6d4c51
to
306aee5
Compare
rebased branch to fix conflict |
I'm not sure KCL was updated in this PR, @jimmidyson had some issues on master branch PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked /ops/portal/kommander/monitoring/karma
on @juliangieseke's cluster, this lgtm 👍
@hectorj2f hm KCL failed ramping up a cluster. I've send details via slack. |
abovementioned error seems to be related to tagging and not to this PR. |
backporting latest master bump (this one: #68) to 1.3.0 branch. it shouldnt impact konvoy in any way, only updating kommander addon. will do some final tests with this branch tho.
How to test?
create cluster.yaml and change
configVersion
to this branch: