Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[1.3.0] backport latest kommander bump #84

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

juliangieseke
Copy link
Contributor

@juliangieseke juliangieseke commented Jan 16, 2020

backporting latest master bump (this one: #68) to 1.3.0 branch. it shouldnt impact konvoy in any way, only updating kommander addon. will do some final tests with this branch tho.

How to test?

create cluster.yaml and change configVersion to this branch:

addons:
    - configRepository: https://github.com/mesosphere/kubernetes-base-addons
      configVersion: jg/kommander-backport-1.3

@juliangieseke juliangieseke changed the title chore: bump kommander addon [1.3.0] backport latest kommander bump Jan 16, 2020
@juliangieseke
Copy link
Contributor Author

blocked until I did cluster tests

@hectorj2f
Copy link

@juliangieseke I added a commit with one of our required changes (that we merged today) :).

@juliangieseke
Copy link
Contributor Author

The Cluster I ramped up with my initial state of this PR looks good. can someone else please pick up this PR? there also seems to be a merge conflict now :(

@juliangieseke
Copy link
Contributor Author

actually, @hectorj2f why are these lines removed? AFAIK UI depends on them. cc @natmegs

@natmegs
Copy link
Contributor

natmegs commented Jan 16, 2020

@juliangieseke I believe these were needed before for KCL to know which version of kubeaddons to use based on given k8s version. @hectorj2f is this now being defaulted in some other way?

@juliangieseke juliangieseke force-pushed the jg/kommander-backport-1.3 branch from c6d4c51 to 306aee5 Compare January 16, 2020 18:39
@juliangieseke
Copy link
Contributor Author

rebased branch to fix conflict

@juliangieseke
Copy link
Contributor Author

I'm not sure KCL was updated in this PR, @jimmidyson had some issues on master branch PR

Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked /ops/portal/kommander/monitoring/karma on @juliangieseke's cluster, this lgtm 👍

@juliangieseke
Copy link
Contributor Author

juliangieseke commented Jan 16, 2020

@hectorj2f hm KCL failed ramping up a cluster. I've send details via slack.

@juliangieseke
Copy link
Contributor Author

abovementioned error seems to be related to tagging and not to this PR.

@alejandroEsc alejandroEsc merged commit 0ad330a into v1.3.0-rc.1 Jan 16, 2020
@alejandroEsc alejandroEsc deleted the jg/kommander-backport-1.3 branch January 16, 2020 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants