This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Use self.host property once in get_event_stream #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is twice get on the host attribute, when we setup with two marathons, the first is online and the second is offline. It will always requests the bad marathon.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
ok to test |
ichernetsky
changed the title
|
@sharego, thanks a lot for your contribution and your patience. I reviewed the patch, and I will make sure that it gets merged in no time. |
ichernetsky
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.hostcycles through available Marathon URLs, and it was accessed twice inget_event_stream, which made it access the same Marathon instance, if two URLs were supplied, which is especially profound if the instance being accessed over and over again is down.