Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Wiring for pods in legacy storage isn't fully implemented. #4842

Closed
jasongilanfarr opened this issue Dec 14, 2016 · 2 comments · Fixed by dcos/dcos#1086
Closed

Wiring for pods in legacy storage isn't fully implemented. #4842

jasongilanfarr opened this issue Dec 14, 2016 · 2 comments · Fixed by dcos/dcos#1086
Assignees
@aquamatthias

Comments

@jasongilanfarr
Copy link
Contributor

jasongilanfarr commented Dec 14, 2016 •
edited by aquamatthias
Loading

Missing addDeprecatedPods in RootGroup.
@jasongilanfarr jasongilanfarr added this to the Marathon 1.4 milestone Dec 14, 2016
@jasongilanfarr
Copy link
Contributor Author

Essentially, if the legacy backend is selected, pods don't persist. - root/group to/from Proto is missing pod support.

@aquamatthias aquamatthias self-assigned this Dec 15, 2016
@aquamatthias
Copy link
Contributor

https://phabricator.mesosphere.com/D342

@unterstein unterstein mentioned this issue Dec 15, 2016
Closed
6 tasks
aquamatthias added a commit that referenced this issue Dec 21, 2016
@aquamatthias
Fixes #4842 by also writing deprecated pods to the proto.
380f5d6 
Summary: Added a test case which shows the round trip works.

Test Plan:
#1 sbt test
#2 start marathon with --internal_store_backend legacy_zk, create pods, restart marathon and get pods and the root group.

Reviewers: unterstein, jasongilanfarr

Reviewed By: unterstein, jasongilanfarr

Subscribers: jenkins, marathon-team

Differential Revision: https://phabricator.mesosphere.com/D342

(cherry picked from commit 6578976)
@aquamatthias aquamatthias mentioned this issue Dec 21, 2016
Merged
5 tasks
@d2iq-archive d2iq-archive locked and limited conversation to collaborators Mar 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aquamatthias aquamatthias

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Marathon 1.4.0-RC4. aquamatthias/dcos
3 participants
@aquamatthias @jasongilanfarr @unterstein