Add Network.Name to IpAddress

[ozdanborne]

This PR adds the optional field ipAddress.Name, which is read and written as an optional field in ContainerInfo.NetworkInfo.Name.

This branch successfully builds but fails to pass the existing tests, presumably because I am incorrectly reading and storing the nullable string from the protobuf.

Not looking to merge this until the first commit (bump to Mesos 1.0.0 protobufs) is mainlined through the official mesos-utils build system. But am looking to get this working ASAP as early access to CNI plugins. Can anyone provide some scala-foo for what I may be doing wrong?

[ozdanborne]

Some sample test failures:

- BuildIfMatchesWithIpAddress *** FAILED *** (6 milliseconds)
  0 was not equal to 1 (TaskBuilderTest.scala:588)

- BuildIfMatchesWithIpAddressAndCustomExecutor *** FAILED *** (6 milliseconds)
  0 was not equal to 1 (TaskBuilderTest.scala:639)

- BuildIfMatchesWithIpAddressAndDiscoveryInfo *** FAILED *** (4 milliseconds)
  0 was not equal to 1 (TaskBuilderTest.scala:694)

[ozdanborne]

Cool, I was just missing one embarrassing line. This all seems to be working now. Is there any other work that needs to be done while we wait for 1.0.0 mesos-utils to drop? Presumably just:

• tests
• documentation

[jdef]

just merged this morning: 731b4d4

if this meets the need, can we close this out?

[kensipe]

@djosborne is the feature merge provided by jdef sufficient? can we close this?

[ozdanborne]

@kensipe I built from master last week after it was merged and was unable to get a task to launch with CNI. I will retry with latest master and close if it works, or post debug info if it does not.

[ozdanborne]

Just got this working. The network names that have been added are sufficient for CNI for Mesos tasks.

FYI I was running into an issue where Marathon was complaining that 1.0.0 protobufs were imcompatible with Mesos 0.28.2. Apparently the main Dockerfile installs Mesos 0.28.2, whereas Dockerfile.development correctly installs 1.0.0-rc1. I can raise an issue if this is not being tracked

[ozdanborne]

@jdef Just launched a Docker task on a Docker UDN using the new Api. All worked as expected. Nice!

[jkidambi]

Is there a plan to support the labels field mentioned in http://mesos.apache.org/documentation/cni/?

[ozdanborne]

@jkidambi That's currently supported. Marathon's ipAddress.labels field gets pushed into Networkinfo.labels. More info here: https://mesosphere.github.io/marathon/docs/ip-per-task.html

[jkidambi]

@djosborne Thanks. I did figure that out after I posted that question, and have been able to successfully test it end-to-end.

[jkidambi]

@djosborne Is there a way to specify multiple networks per container? I'm not seeing a way to do that. If there is a better place to post such questions, I'll do so.

[ozdanborne]

@jkidambi I don't think there is currently. I think since configurable networking for Mesos is a relatively new concept, use cases for multi-network tasks hasn't been clearly ironed out yet, and there's not a lot of support for it yet.