-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating method parameters #1982
Conversation
changing method from "test_feature" to "test_features"
Job d2l-en/PR-1982/1 is complete. |
Hi, The link "http://preview.d2l.ai/d2l-en/PR-1982/" just forwards me to the d2l.ai home page. I'm not able to view any build results. Please let me know if the PR needs to be created on a branch different than the "release" one. The master branch doesn't have as many pages as the release one and is way behind it when comes to commits. |
Thanks. Can you send your PR to r0.17 branch? |
Let's wait for the CI before merging this. |
@d2l-bot please rebuild! |
Job d2l-en/PR-1982/2 is complete. |
Job d2l-en/PR-1982/3 is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! LGTM
@gopalakrishna-r Thanks! Could you send another PR to replace your github id with your name in our acknowledgement? |
referencing d2l-ai#1982 (comment) file changed to include name
Thanks for the acknowledgment. Here's the PR for including the name. |
referencing #1982 (comment) file changed to include name
changing method parameter from "test_feature" to "test_features"
Description of changes:
By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.