Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating method parameters #1982

Merged
merged 1 commit into from
Mar 15, 2022
Merged

updating method parameters #1982

merged 1 commit into from
Mar 15, 2022

Conversation

gopalakrishna-r
Copy link
Contributor

changing method parameter from "test_feature" to "test_features"

Description of changes:

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

changing method from "test_feature" to "test_features"
@mli
Copy link
Member

mli commented Dec 6, 2021

Job d2l-en/PR-1982/1 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-1982/

@gopalakrishna-r
Copy link
Contributor Author

Hi,

The link "http://preview.d2l.ai/d2l-en/PR-1982/" just forwards me to the d2l.ai home page. I'm not able to view any build results.

Please let me know if the PR needs to be created on a branch different than the "release" one. The master branch doesn't have as many pages as the release one and is way behind it when comes to commits.

@astonzhang
Copy link
Member

Thanks. Can you send your PR to r0.17 branch?

@AnirudhDagar AnirudhDagar changed the base branch from release to r0.17 February 24, 2022 10:03
@AnirudhDagar
Copy link
Member

Let's wait for the CI before merging this.

@AnirudhDagar
Copy link
Member

@d2l-bot please rebuild!

@d2l-bot
Copy link
Member

d2l-bot commented Mar 8, 2022

Job d2l-en/PR-1982/2 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-1982/

@d2l-bot
Copy link
Member

d2l-bot commented Mar 15, 2022

Job d2l-en/PR-1982/3 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-1982/

Copy link
Member

@AnirudhDagar AnirudhDagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM

@AnirudhDagar AnirudhDagar merged commit c557734 into d2l-ai:r0.17 Mar 15, 2022
@astonzhang
Copy link
Member

@gopalakrishna-r Thanks! Could you send another PR to replace your github id with your name in our acknowledgement?
https://github.com/d2l-ai/d2l-en/blob/master/chapter_preface/index.md

gopalakrishna-r added a commit to gopalakrishna-r/d2l-en-1 that referenced this pull request Mar 16, 2022
referencing d2l-ai#1982 (comment)

file changed to include name
@gopalakrishna-r
Copy link
Contributor Author

Thanks for the acknowledgment. Here's the PR for including the name.
#2069 (comment)

astonzhang pushed a commit that referenced this pull request Mar 16, 2022
referencing #1982 (comment)

file changed to include name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants