Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] hotfix r0.17.2 #2009

Merged
merged 4 commits into from
Jan 16, 2022
Merged

[PyTorch] hotfix r0.17.2 #2009

merged 4 commits into from
Jan 16, 2022

Conversation

AnirudhDagar
Copy link
Member

@AnirudhDagar AnirudhDagar commented Jan 14, 2022

Description of changes:
The following sections are fixed:

  • The hotdog class in imagenet is number 934 instead of 713.
  • 1/2 is added back in mseloss for chapter_optimization in train_concise_ch11 because the plots won't show since without the 1/2 the loss gets doubled and the ylim of the training curve has been fixed between 0.22 and 0.35. Without the 1/2 factor the loss never shows up on the plots.
  • lr=0.01 makes learning smoother in the updated notebooks.
  • l.mean() instead of l.sum() (in the weight-decay section) is more stable, producing the expected plots.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

@mli
Copy link
Member

mli commented Jan 14, 2022

Job d2l-en/PR-2009/1 is complete.
Check the results at http://preview.d2l.ai/d2l-en/PR-2009/

@astonzhang
Copy link
Member

Thanks. I'll move the comments # Note: MSELoss computes squared error without the 1/2 factor closer to the multiplication by 1/2 to improve readability.

@astonzhang astonzhang merged commit dd08847 into d2l-ai:r0.17 Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants