Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash on missing top bin #248

Merged
merged 5 commits into from
Apr 7, 2022
Merged

fix crash on missing top bin #248

merged 5 commits into from
Apr 7, 2022

Commits on Apr 7, 2022

  1. fix https://observablehq.com/@weiglemc/demonstrating-issue-with-d3-bi… 

    …ns-in-d3v7-4-1-update

unit test: d3.bin().domain([4, 5])([5])
the issue is that we have removed the last bin, but then want to assign the largest value to it because floor(x1) === x1

I'm not sure if the fix catches all cases…
    @Fil
    Fil committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    78686cf View commit details
    Browse the repository at this point in the history

  2. nicer

    @Fil
    Fil committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    907b54a View commit details
    Browse the repository at this point in the history

  3. another test that crashes

    @Fil
    Fil committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    3d1b425 View commit details
    Browse the repository at this point in the history

  4. in this case we had step == -1

    @Fil
    Fil committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    8d50704 View commit details
    Browse the repository at this point in the history

  5. m

    @mbostock
    mbostock committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    ce85eef View commit details
    Browse the repository at this point in the history