In d3.histogram, the rightmost bin by default thresholds is too wide #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice to meet you.
d3.histogram()(data)
returns bins their width are automatically determined by default thresholds.I understand that widths of middle bins are fixed and widths of edge bins (leftmost and rightmost) are less or equal to the fixed width. But sometimes the rightmost bin may have wider width.
For example, the result of code below has wider rightmost bin:
I expect that the last part of bins should be:
In src/hitogram.js#L33, the default thresholds are generated by:
I think that this
Math.floor
is not needed because result ofrange(a, b, c)
already does not includeb
(isn't it?).