Abs weighted average in manyBody barnes-hut coords #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quadrant coordinates for the Barnes-Hut approx in forceManyBody are calculated using a weighted average according to the child strengths. However, the current calc is not accounting for negative strengths which may throw off the
quad.x
/quad.y
coords. Furthermore the issue is aggravated when combining positive and negative strengths, which will result in a reduced aggregated strength (due to cancellation), leading to very high values ofx
andy
.I came across the issue when noticing combined nodes with positive and negative strengths having a much lower force intensity, due to the quadrant centers being much more distant.
This patch abs the weights in the average to fix the issue.