-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use midpoint of range with collapsed domains? #117
Comments
Fixed in #156. |
mbostock
added a commit
that referenced
this issue
Jan 26, 2019
This was referenced Jul 3, 2019
Fil
added a commit
to romsson/d3-gridding
that referenced
this issue
Dec 3, 2019
See #29 Unfortunately we can't build with d3-scale > 2.1.2, there is an incompatibility with https://github.com/d3/d3-scale/releases/tag/v2.2.0 — probably due to d3/d3-scale#117
This was referenced Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extracted from #113: when a scale has a collapsed domain (or domain segment), we currently map the value to the start of the corresponding range (or range segment). For example:
This is of course arbitrary; it should be valid to return any value in the corresponding range. The current implementation uses constant(0) in this case, but it should be a matter of using constant(0.5) instead:
d3-scale/src/continuous.js
Lines 9 to 13 in 4c8c282
Though, we’ll now have to check explicitly for isNaN(b).
The text was updated successfully, but these errors were encountered: