Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selection.selectChild[ren]. #244

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Add selection.selectChild[ren]. #244

merged 1 commit into from
Aug 12, 2020

Conversation

mbostock
Copy link
Member

Fixes #243.

@mbostock mbostock mentioned this pull request Apr 25, 2020
Closed
Fil added a commit that referenced this pull request Jun 29, 2020
@Fil
document, fix and test #244
b46722d
@Fil Fil added the feature label Jul 10, 2020
@Fil Fil mentioned this pull request Jul 10, 2020
Merged
9 tasks
@Fil
Copy link
Member

Fil commented Jul 23, 2020

Feature branch, ready to merge into two.

mbostock
mbostock commented Jul 23, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/selection/selectChild.js Outdated Show resolved Hide resolved
src/selection/selectChild.js Outdated Show resolved Hide resolved
src/selection/selectChild.js Outdated Show resolved Hide resolved
src/selection/selectChildren.js Outdated Show resolved Hide resolved
src/selection/selectChildren.js Outdated Show resolved Hide resolved
src/selection/selectChildren.js Outdated Show resolved Hide resolved
mbostock
mbostock commented Jul 24, 2020
View reviewed changes
Copy link
Member Author

@mbostock mbostock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@mbostock mbostock merged commit 04e9e75 into two Aug 12, 2020
@mbostock mbostock deleted the two-children branch August 12, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fil Fil Fil left review comments

Assignees
No one assigned
Labels
feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbostock @Fil