Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run de seq 1 0 #28
Run de seq 1 0 #28
Changes from 19 commits
a2dc405
7e078e8
ea59bdf
c57b611
e8a7531
3d86fd5
06407db
83871fe
ccc4463
84a6fb2
1b0edb2
0233eb4
7a6c6a4
839de71
bb072b1
4d9da10
2f89da7
7799441
2a4f68c
db15985
56dd86e
16ec579
d5b1995
e05db28
71ee207
5a968c0
2758172
c30558a
e82e251
d07ac29
0caa7b0
6135f62
192cb4c
77d99b3
d0d571c
8d9b7cd
acd943f
a4982d1
b6f5b81
67dcccb
35a0bd0
5754b69
8128338
f2fe521
90101bf
241aacd
911b68d
a9520b9
94f4cf9
ae4bca1
b83ca38
cc121d2
22dd32f
f9e71bb
8c9f91f
e84cbec
c8fbaf2
1960828
d5d42ac
ca76730
414f7fc
68a5a8a
6cd0284
6c6a5b5
eda8746
374984b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These steps should be reworked - they will not be necessary once you use the independent specimen lists for RNA, which are located here. For this analysis, you should be using the
independent-specimens.rnaseq.primary.tsv
for thecancer_group
level analysis andindependent-specimens.rnaseq.primary.eachcohort.tsv
for thecohort+cancer_group
level analysis.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jharenza . I was wondering if other modules should also use all-cohort independent sample list for all-cohort analysis and use each-cohort independent sample list for each-cohort analysis. Sorry for the digression from this PR.
My concern is that all-cohort and each-cohort independent sample lists currently have very different independent samples due to the random selection procedures, which may cause result discrepancies between only-one-cohort-all-cohort and each-cohort. Such potential discrepancies could be reduced by updating the independent-samples module to favor selecting the same biospecimen IDs that are in the all-cohort sample lists. I estimate this refactoring may take a week, including review time. Even after this refactoring, there will still be result discrepancies between only-one-cohort-all-cohort and each-cohort, but these discrepancies will not be caused by random selection but rather overlapping patients between cohorts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the plan so that all analyses for RNA and DNA use the same lists, which may be updated per release if/when new data is added.
This is a good point and makes sense to do - can you submit a ticket for that? I would perhaps call that a medium priority task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that all analyses should use the same lists.
Sure. I will submit a ticket for updating the independent sample lists. I will also submit a couple of other tickets for analysis modules to update the independent sample lists being used and label them with blocked and referring to the independent sample lists update ticket, so that all-cohort analysis uses all-cohort independent lists, and each-cohort analysis uses each-cohort independent sample lists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can remove this if above in line 56, you do a selection for GTEX cohort (there are no NAs in that cohort list) before selecting the subgroups into a list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to note somewhere in the module or result table that the log fold change in the result is GTEX / cancer_group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not all
rownames(Result)
are inrownames(TPMData_filtered)
, match(rownames(Result),rownames(TPMData_filtered)) will haveNA
s in them, so the selection will have NA as rows.My suggestion is to remove any existing NA in the
match
result before using it for selection.Similarly for other
match
expressions below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest to give this table a more descriptive name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out_dir
suggestion