Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python3.11 sre module import #6

Closed
wants to merge 2 commits into from

Conversation

Lolimpo
Copy link
Contributor

@Lolimpo Lolimpo commented Nov 17, 2022

After CPython 3.11 re module reorganization, sre_* modules were removed. Add variable import of that modules for different CPython versions.

CPython description: python/cpython#91308

@codecov-commenter
Copy link

Codecov Report

Base: 99.17% // Head: 97.82% // Decreases project coverage by -1.35% ⚠️

Coverage data is based on head (2d4f7cb) compared to base (a1e7ff5).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master       #6      +/-   ##
==========================================
- Coverage   99.17%   97.82%   -1.36%     
==========================================
  Files           6        5       -1     
  Lines         243      230      -13     
  Branches       52       53       +1     
==========================================
- Hits          241      225      -16     
- Misses          2        4       +2     
- Partials        0        1       +1     
Impacted Files Coverage Δ
blahblah/_regex_generator.py 96.77% <50.00%> (-3.23%) ⬇️
blahblah/_generator.py 100.00% <0.00%> (ø)
blahblah/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@d42-schemas d42-schemas deleted a comment from Lolimpo Nov 19, 2022
@tsv1
Copy link
Collaborator

tsv1 commented Nov 24, 2022

Fixed linter here #7

Thanks!

@tsv1 tsv1 closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants