Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClusterFuzzLite integration #152

Closed

Conversation

DavidKorczynski
Copy link

This adds fuzzing by way of ClusterFuzzLite, which is a GitHub action that will perform a short amount of fuzzing for new PRs. The goal is to use fuzzing to catch bugs that may be introduced by new PRs.

I added a fuzzer that targets the parsing logic, and currently set the timeout of CFLite to 100 seconds. CFLite will flag if the fuzzer finds any issues in the code introduced by a PR.

Signed-off-by: David Korczynski <david@adalogics.com>
@d99kris d99kris self-assigned this Dec 22, 2023
Signed-off-by: David Korczynski <david@adalogics.com>
@d99kris
Copy link
Owner

d99kris commented Jan 27, 2024

Hi @DavidKorczynski - thanks for contributing. I hope to find some time soon to review the changes, but from a quick look I'm not sure it's a good fit for this project. Ideally I'd like all tests to be runnable locally (via ./make.sh tests which effectively just calls ctest) with minimum external dependencies (ideally having test code contained within the rapidcsv repository itself) and being able to reproduce a test run (not sure if this fuzzer uses a random seed or whether one can specify it).

Anyway, I haven't studied the proposed changes in detail, so I'll update here again once I have.

@d99kris
Copy link
Owner

d99kris commented Apr 28, 2024

After some consideration I have decided not to merge the PR, mainly for the reasons listed in my above comment. I will proceed to close the PR.

@d99kris d99kris closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants