Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbp 618 ausfuehren der playwright tests fuer beliebige branches #10

Conversation

JannikBadenhop
Copy link
Contributor

Description

Change action to:

  • add workflow_call event trigger
  • add optional input variable frontendHostname for workflow dispatch
  • add optional env variable FRONTEND_URL for job "test" which defaults to "helm.dev.spsh.dbildungsplattform.de"

Links to Tickets or other PRs

Notes

Approval for review

  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

- run on opened PRs to main *instead of* pushes on main
- add input variable frontendHostname for workflow dispatch
- add env variable FRONTEND_URL for job "test" which defaults to "helm.dev.spsh.dbildungsplattform.de"
- remove default from frontendHostname input
- only set FRONTEND_URL frontendHostname is given
@JannikBadenhop JannikBadenhop requested a review from a team February 22, 2024 15:39
@JannikBadenhop JannikBadenhop self-assigned this Feb 22, 2024
@JannikBadenhop JannikBadenhop merged commit b5e0184 into main Feb 23, 2024
2 of 3 checks passed
@JannikBadenhop JannikBadenhop deleted the DBP-618-Ausfuehren_der_Playwright-Tests_fuer_beliebige_Branches branch February 23, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants