Switch network to DAO network if opened by url #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tezos-homebase ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Manank Patni <manank321@gmail.com>
Man-Jain
force-pushed
the
network-switch-patch
branch
from
a4a1f2f
to
c2b080c
Compare
thenerdcat
approved these changes
Nov 14, 2022
EightRice
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks for the network of the DAO and if it doesn't match the current network the changeNetwork is called and switched to DAO's network.
A better solution for future would be to put the network in the network URL and only triggering network switch if user interact with DAO, until then the DAO should work normally. A similar approach is in Issue #259