Explorer tabs upgrade #485

fabiolalombardim · 2023-01-28T22:13:01Z

Modified existing "Proposal" tab according to Figma
Added new "Config" tab

commit b4bb2cc Author: fabiolalombardim <lombardifabiola@hotmail.com> Date: Wed Dec 21 12:16:17 2022 +0100 internal link to Lite

…to develop

netlify · 2023-01-28T22:13:16Z

✅ Deploy Preview for tezos-homebase ready!

Name	Link
🔨 Latest commit	`3a903de`
🔍 Latest deploy log	https://app.netlify.com/sites/tezos-homebase/deploys/63e78203aa32140008417357
😎 Deploy Preview	https://deploy-preview-485--tezos-homebase.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thenerdcat · 2023-01-30T11:43:22Z

Approved. But on Mobile this section of the Config Page is not fully responsive . We could create a separate task for fixing this.

thenerdcat · 2023-01-30T11:44:24Z

this is how it looks on mobile. the variables are not visible

Man-Jain

This should be "Execute Lambda" - "Execute a Lambda already Installed on DAO"

Man-Jain

The formula that we apply when taking input from the user and sending the values in the contract (

homebase-app/src/services/contracts/baseDAO/utils.ts

Line 14 in b90a4a1

    
           const proposalFlush = 2 * info.votingSettings.votingBlocks + info.votingSettings.proposalFlushBlocks

and

homebase-app/src/services/contracts/baseDAO/utils.ts

Line 15 in b90a4a1

const expiryPeriod = proposalFlush + info.votingSettings.proposalExpiryBlocks

) should be reverse engineered so we show the users the same values they put in otherwise they'll be confused.

Man-Jain

Should show the governance Token Symbol here at the end.

fabiolalombardim · 2023-01-31T11:55:46Z

Responsive tables fixed

netlify · 2023-01-31T20:34:21Z

manank left a comment:

This should be 49 and 3, XTZ everywhere should be divided by 10 ** 6

Browser metadata

Path:      /explorer/dao/KT1UCEscNaP7dj6FsKrGezDrxuak8b9ibHxp/config
Browser:   Firefox 109.0 on Mac OS 10.15
Viewport:  1512 x 831 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Man-Jain · 2023-01-31T22:52:25Z

This should not be %age but should be 20000200000.004 GovernanceTokenSymbol

Browser metadata

Path:      /explorer/dao/KT1UCEscNaP7dj6FsKrGezDrxuak8b9ibHxp/config
Browser:   Firefox 109.0 on Mac OS 10.15
Viewport:  1512 x 831 @2x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

…to develop

Man-Jain · 2023-02-10T22:57:35Z

The formula that we apply when taking input from the user and sending the values in the contract (

homebase-app/src/services/contracts/baseDAO/utils.ts

Line 14 in b90a4a1

const proposalFlush = 2 * info.votingSettings.votingBlocks + info.votingSettings.proposalFlushBlocks

and

homebase-app/src/services/contracts/baseDAO/utils.ts

Line 15 in b90a4a1

const expiryPeriod = proposalFlush + info.votingSettings.proposalExpiryBlocks

) should be reverse engineered so we show the users the same values they put in otherwise they'll be confused.

This hasn't been resolved

Man-Jain · 2023-02-10T23:02:13Z

This should be "Execute Lambda" - "Execute a Lambda already Installed on DAO"

This also hasn't been resolved

* Add FA1.2 support and remove banner (#489) Signed-off-by: Manank Patni <manank321@gmail.com> * Fix README.md Signed-off-by: Manank Patni <manank321@gmail.com> * Explorer tabs upgrade and add config page (#485) * Squashed commit of the following: commit b4bb2cc Author: fabiolalombardim <lombardifabiola@hotmail.com> Date: Wed Dec 21 12:16:17 2022 +0100 internal link to Lite * title block updated & buttons removed * table filter * clean up * dao info tables * updated missing field * removed material ui styles * clean up * removed view code button * responsive tables * requested changes * delete console.log * execute text updated * formulas added * Add banner for Humanitarian DAO and remove banner one time limit Signed-off-by: Manank Patni <manank321@gmail.com> * DAO Creator updates and improvements (#495) * Squashed commit of the following: commit b4bb2cc Author: fabiolalombardim <lombardifabiola@hotmail.com> Date: Wed Dec 21 12:16:17 2022 +0100 internal link to Lite * added tooltip for token id * fixed conditional votting settings depending on network * estimated blocks * update initialization of values * useBlocks * useBlocks updated * values updated --------- Signed-off-by: Manank Patni <manank321@gmail.com> Co-authored-by: fabiolalombardim <37227394+fabiolalombardim@users.noreply.github.com> Co-authored-by: Fernando Torres <80982814+thenerdcat@users.noreply.github.com>

* Merge Develop to Master (#500) * Add FA1.2 support and remove banner (#489) Signed-off-by: Manank Patni <manank321@gmail.com> * Fix README.md Signed-off-by: Manank Patni <manank321@gmail.com> * Explorer tabs upgrade and add config page (#485) * Squashed commit of the following: commit b4bb2cc Author: fabiolalombardim <lombardifabiola@hotmail.com> Date: Wed Dec 21 12:16:17 2022 +0100 internal link to Lite * title block updated & buttons removed * table filter * clean up * dao info tables * updated missing field * removed material ui styles * clean up * removed view code button * responsive tables * requested changes * delete console.log * execute text updated * formulas added * Add banner for Humanitarian DAO and remove banner one time limit Signed-off-by: Manank Patni <manank321@gmail.com> * DAO Creator updates and improvements (#495) * Squashed commit of the following: commit b4bb2cc Author: fabiolalombardim <lombardifabiola@hotmail.com> Date: Wed Dec 21 12:16:17 2022 +0100 internal link to Lite * added tooltip for token id * fixed conditional votting settings depending on network * estimated blocks * update initialization of values * useBlocks * useBlocks updated * values updated --------- Signed-off-by: Manank Patni <manank321@gmail.com> Co-authored-by: fabiolalombardim <37227394+fabiolalombardim@users.noreply.github.com> Co-authored-by: Fernando Torres <80982814+thenerdcat@users.noreply.github.com> * Revert "Merge Develop to Master (#500)" (#517) This reverts commit c04c7d8. * Upgrade beacon version (#531) * Upgrade beacon version Signed-off-by: Manank Patni <manank321@gmail.com> * Upgrade beacon version Signed-off-by: Manank Patni <manank321@gmail.com> * Remove connect on originate and save beacon wallet instance Signed-off-by: Manank Patni <manank321@gmail.com> --------- Signed-off-by: Manank Patni <manank321@gmail.com> * Fix validations Signed-off-by: Manank Patni <manank321@gmail.com> * Add decimal validation to block number Signed-off-by: Manank Patni <manank321@gmail.com> --------- Signed-off-by: Manank Patni <manank321@gmail.com> Co-authored-by: fabiolalombardim <37227394+fabiolalombardim@users.noreply.github.com> Co-authored-by: Fernando Torres <80982814+thenerdcat@users.noreply.github.com>

fabiolalombardim added 15 commits December 21, 2022 12:30

Squashed commit of the following:

d069041

commit b4bb2cc Author: fabiolalombardim <lombardifabiola@hotmail.com> Date: Wed Dec 21 12:16:17 2022 +0100 internal link to Lite

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

740680c

…to develop

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

cb8245d

…to develop

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

8cbe0d7

…to develop

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

8a1590f

…to develop

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

435639f

…to develop

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

a56b6e9

…to develop

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

c66cef7

…to develop

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

1830e65

…to develop

title block updated & buttons removed

e5bd629

table filter

e11c8c7

clean up

b7e8e24

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

10436dd

…to develop

Merge branch 'develop' into explorer-tabs-upgrade

a4081ff

dao info tables

145449b

fabiolalombardim added 3 commits January 29, 2023 14:42

updated missing field

890bd96

removed material ui styles

bbee78e

clean up

4674f11

fabiolalombardim changed the title ~~[WIP] Explorer tabs upgrade~~ Explorer tabs upgrade Jan 29, 2023

removed view code button

dcd5e0e

fabiolalombardim requested review from Man-Jain, EightRice and thenerdcat January 29, 2023 14:51

thenerdcat approved these changes Jan 30, 2023

View reviewed changes

Man-Jain requested changes Jan 30, 2023

View reviewed changes

responsive tables

c69f49c

EightRice approved these changes Jan 31, 2023

View reviewed changes

EightRice self-requested a review January 31, 2023 17:42

EightRice approved these changes Jan 31, 2023

View reviewed changes

Merge branch 'develop' of https://github.com/dOrgTech/homebase-app in…

d6a0e2c

…to develop

EightRice requested a review from Man-Jain February 7, 2023 19:35

fabiolalombardim added 3 commits February 7, 2023 20:35

Merge branch 'develop' into explorer-tabs-upgrade

9d8cb24

requested changes

e3c3f17

delete console.log

6384b3e

fabiolalombardim added 2 commits February 11, 2023 11:36

execute text updated

b5e0bf0

formulas added

3a903de

Man-Jain approved these changes Feb 11, 2023

View reviewed changes

Man-Jain merged commit c33f88d into develop Feb 11, 2023

Man-Jain deleted the explorer-tabs-upgrade branch February 11, 2023 14:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Explorer tabs upgrade #485

Explorer tabs upgrade #485

fabiolalombardim commented Jan 28, 2023

netlify bot commented Jan 28, 2023 •

edited

Loading

thenerdcat commented Jan 30, 2023

thenerdcat commented Jan 30, 2023

Man-Jain left a comment •

edited

Loading

Man-Jain left a comment •

edited

Loading

Man-Jain left a comment •

edited

Loading

fabiolalombardim commented Jan 31, 2023

netlify bot commented Jan 31, 2023 •

edited by Man-Jain

Loading

Man-Jain commented Jan 31, 2023 •

edited

Loading

Man-Jain commented Feb 10, 2023

Man-Jain commented Feb 10, 2023

Explorer tabs upgrade #485

Explorer tabs upgrade #485

Conversation

fabiolalombardim commented Jan 28, 2023

netlify bot commented Jan 28, 2023 • edited Loading

✅ Deploy Preview for tezos-homebase ready!

thenerdcat commented Jan 30, 2023

thenerdcat commented Jan 30, 2023

Man-Jain left a comment • edited Loading

Choose a reason for hiding this comment

Man-Jain left a comment • edited Loading

Choose a reason for hiding this comment

Man-Jain left a comment • edited Loading

Choose a reason for hiding this comment

fabiolalombardim commented Jan 31, 2023

netlify bot commented Jan 31, 2023 • edited by Man-Jain Loading

Man-Jain commented Jan 31, 2023 • edited Loading

Man-Jain commented Feb 10, 2023

Man-Jain commented Feb 10, 2023

netlify bot commented Jan 28, 2023 •

edited

Loading

Man-Jain left a comment •

edited

Loading

Man-Jain left a comment •

edited

Loading

Man-Jain left a comment •

edited

Loading

netlify bot commented Jan 31, 2023 •

edited by Man-Jain

Loading

Man-Jain commented Jan 31, 2023 •

edited

Loading