Handle CJK rendering #263
Open
Handle CJK rendering #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medicalwei
force-pushed
the
handle-cjk-rendering
branch
from
6aa1d97 to
42b1b5d
Compare
|
Note that this commit would cause slowdowns when editing lines containing too many non-ASCII glyphs, which would imply that performance rendering documents like Cyrillic would be heavily affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset addresses two problems:
LANG=zh_TW), the metrics would be incorrect.This changeset addresses the above problems by making a break in itemizer for every non-ascii characters, as well as forcing the metrics information to be in
en_US. This assumes that monospace fonts have all ASCII glyphs. Also, this would cause ligatures in non-ASCII fail.Closes #256