Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorge to scan local modules directory #5

Merged
merged 3 commits into from
Jun 21, 2024
Merged

gorge to scan local modules directory #5

merged 3 commits into from
Jun 21, 2024

Conversation

johnwarburton
Copy link
Contributor

Hi @dadav

Use case is gorge running as a local puppet forge for in house build puppet modules

When a new module is built, we would drop it into the local modules directory

We would like gorge to scan the local modules directory on a regular basis to pick up module updates. This PR gives us the ability to scan the local module on a regular basis. The default is the current behaviour - only scan on startup

Please let me know if you need anything else to accept this PR

Regards

John

@dadav
Copy link
Owner

dadav commented Jun 20, 2024

Hi @johnwarburton ,

Thanks for this awesome PR. I think we need a way to make sure to cleanup that goroutine...

@johnwarburton
Copy link
Contributor Author

Thanks @dadav - any suggestions on cleaning up the goroutine? This is my first attempt at writing go, so any pointers would be appreciated

@johnwarburton
Copy link
Contributor Author

Hi @dadav - I had a chat with one of our go gurus and they suggested tidying up the code to remove some redundancies - was this what you meant by "cleanup"?

Thanks!

@dadav
Copy link
Owner

dadav commented Jun 21, 2024

Hi @dadav - I had a chat with one of our go gurus and they suggested tidying up the code to remove some redundancies - was this what you meant by "cleanup"?

Thanks!

With cleanup I mean to prevent goroutine leaks. We need a way to tell the goroutine when to exit, which usually is when the user presses Ctrl+c or SIGTERM is sent.

I can help with this.

@dadav dadav merged commit 4957de3 into dadav:main Jun 21, 2024
1 check passed
@johnwarburton
Copy link
Contributor Author

wow - thanks @dadav - next level stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants