-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed bahavior upgrading from 0.8.0 to 0.8.1 #303
Comments
@daddyz did you see this? |
@tilo interesting undocumented behavior. I never saw that method being used like that, it's not documented and not tested. I tried it locally on 0.8.9 and it works. Can you specify your ruby version? |
@tilo can you test latest version? |
regardless, there is a configuration option that allows several countries: Phonelib.default_country = ['US', 'CA']
phone = Phonelib.parse(phone_number) |
@tilo check version 0.9.1, I saw this happening for possible numbers only, with valid numbers it was working properly |
looks like our tests are passing with 0.9.1 |
great, closing the issue |
looks like the API for PhoneLib changed from version 0.8.0 to 0.8.1
before you could do this:
phone = Phonelib.parse(phone_number, ["US", "CA"])
now you have to do this:
-> there was no test coverage
-> see https://semver.org/
The text was updated successfully, but these errors were encountered: