Sourcery refactored master branch #2

sourcery-ai · 2023-11-27T20:02:19Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-11-27T20:02:21Z

FormalDerivative.py

-  return [(x[0] * x[1], x[1] - 1) for x in Fx if (x[1]-1) > -1]
+  return [(x[0] * x[1], x[1] - 1) for x in Fx if x[1] > 0]


Function FormalDerivative refactored with the following changes:

Simplify numeric comparison (simplify-numeric-comparison)

sourcery-ai · 2023-11-27T20:02:21Z

binGCD.py

-        if b & 1 == 0:
-            return gcd(a, b >> 1)
-        else:
-            return gcd(abs(a - b), min(a, b))
+        return gcd(a, b >> 1) if b & 1 == 0 else gcd(abs(a - b), min(a, b))
    else:
-        if b & 1 == 1:
-            return gcd(a >> 1, b)
-        else:
-            return 2 * gcd(a >> 1, b >> 1)
+        return gcd(a >> 1, b) if b & 1 == 1 else 2 * gcd(a >> 1, b >> 1)


Function gcd refactored with the following changes:

Replace if statement with if expression [×2] (assign-if-exp)

sourcery-ai · 2023-11-27T20:02:21Z

dft.py

-    tmp = []
-    for n in range(0, N / 2):
-        tmp.append(histogram[n] * 2)
-    return tmp
+    return [histogram[n] * 2 for n in range(0, N / 2)]


Function nyquist_norm refactored with the following changes:

Convert for loop into list comprehension (list-comprehension)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-11-27T20:02:21Z

dx.py

-    r = (f(x + h / 2) - f(x - h / 2)) / h
-    return r
+    return (f(x + h / 2) - f(x - h / 2)) / h


Function __df refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-11-27T20:02:21Z

e.py

-    ret = (1 + (1.0 / x)) ** x
-    return ret
+    return (1 + (1.0 / x)) ** x


Function direct_e refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-11-27T20:02:22Z

newton_method.py

-    for i in range(max_iterations):
-        y = f(x0)
-        yprime = f_prime(x0)
-        if abs(yprime) < epsilon:       # Stop if the denominator is too small
-            break
-        x1 = x0 - y / yprime            # Do Newton's computation
-        if abs(x1 - x0) <= tolerance:   # Stop when the result is within the desired tolerance
-            return x1                   # x1 is a solution within tolerance and maximum number of iterations
-        x0 = x1                         # Update x0 to start the process again
-    return None
+	for _ in range(max_iterations):
+		y = f(x0)
+		yprime = f_prime(x0)
+		if abs(yprime) < epsilon:       # Stop if the denominator is too small
+		    break
+		x1 = x0 - y / yprime            # Do Newton's computation
+		if abs(x1 - x0) <= tolerance:   # Stop when the result is within the desired tolerance
+		    return x1                   # x1 is a solution within tolerance and maximum number of iterations
+		x0 = x1                         # Update x0 to start the process again
+	return None


Function newtons_method refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

sourcery-ai · 2023-11-27T20:02:22Z

polysolv.py

-        if i == 0:
-            R[i] = P[i]
-        else:
-            R[i] = P[i] + Q * R[i - 1]
+        R[i] = P[i] if i == 0 else P[i] + Q * R[i - 1]


Function poly_synthetic_div refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-27T20:02:22Z

polysolv.py

-        tmp2.append(r)
-        tmp2.append(-r)
+        tmp2.extend((r, -r))


Function get_rationals refactored with the following changes:

Merge consecutive list appends into a single extend (merge-list-appends-into-extend)

sourcery-ai · 2023-11-27T20:02:22Z

ramanujan_sum.py

-  sum_ = 0
  nipi2 = ipi2 * n
-  for a in range(1, q+1):
-    if gcd(a,q) == 1:
-      sum_ += exp(nipi2 * (a/q))
-  return sum_
+  return sum(exp(nipi2 * (a/q)) for a in range(1, q+1) if gcd(a,q) == 1)


Function c refactored with the following changes:

Move assignment closer to its usage within a block (move-assign-in-block)

Convert for loop into call to sum() (sum-comprehension)

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-11-27T20:02:23Z

redc.py

-    for i in range(1,210):
+    for _ in range(1,210):


Function test refactored with the following changes:

Replace unused for index with underscore (for-index-underscore)

sourcery-ai · 2023-11-27T20:02:24Z

ruffini.py

-    for i in range(2, int(n ** 0.5) + 1):
-        if n % i == 0:
-            return False
-
-    return True
+    return all(n % i != 0 for i in range(2, int(n ** 0.5) + 1))


Function isPrime refactored with the following changes:

Use any() instead of for loop (use-any)

Invert any/all to simplify comparisons (invert-any-all)

sourcery-ai · 2023-11-27T20:02:25Z

ruffini.py

-    factor = sorted(factor)
-    return factor
+    return sorted(factor)


Function factors refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2023-11-27T20:02:25Z

ruffini.py

-        nD.append(-abs(i))
-        nD.append(abs(i))
+        nD.extend((-abs(i), abs(i)))


Function addnegatives refactored with the following changes:

Merge consecutive list appends into a single extend (merge-list-appends-into-extend)

sourcery-ai · 2023-11-27T20:02:25Z

ruffini.py

-        if tmpPoli[len(tmpPoli) - 1] == 0:
+        if tmpPoli[-1] == 0:


Function ruffini_step refactored with the following changes:

Simplify accessing last index of list (simplify-negative-index)

sourcery-ai · 2023-11-27T20:02:25Z

seqmult.py

-        s = list(map(mul, s[0 : l // 2], s[l // 2 :]))
+        s = list(map(mul, s[:l // 2], s[l // 2 :]))


Function SeqMult refactored with the following changes:

Replace a[0:x] with a[:x] and a[x:len(a)] with a[x:] (remove-redundant-slice-index)

sourcery-ai · 2023-11-27T20:02:25Z

sign.py

-    if x >= 0:
-        return x
-    else:
-        return -x
+    return x if x >= 0 else -x


Function _abs refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-27T20:02:25Z

sign.py

-    if x == 0:
-        return 0
-    else:
-        return x / _abs(x)
+    return 0 if x == 0 else x / _abs(x)


Function sign refactored with the following changes:

Replace if statement with if expression (assign-if-exp)

sourcery-ai · 2023-11-27T20:02:25Z

test_inv.py

-  for i in range(2, n):
-    inv.append((p - p // i) * inv[p % i] % p)
+  inv.extend((p - p // i) * inv[p % i] % p for i in range(2, n))


Function compute_modinv_1_n refactored with the following changes:

Replace a for append loop with list extend (for-append-to-extend)

sourcery-ai · 2023-11-27T20:02:25Z

test_inv.py

-  for i in range(1, n):
-    inv.append(int(invert(i, p)))
+  inv.extend(int(invert(i, p)) for i in range(1, n))


Function compute_modinv_gmpy_1_n refactored with the following changes:

Replace a for append loop with list extend (for-append-to-extend)

sourcery-ai · 2023-11-27T20:02:25Z

vectors.py

-    res = 0
-    for n in range(0, len(vec)):
-        res += vec[n] * vec[n]
-
+    res = sum(vec[n] * vec[n] for n in range(0, len(vec)))


Function magnitude refactored with the following changes:

Convert for loop into call to sum() (sum-comprehension)

'Refactored by Sourcery'

0b15853

sourcery-ai bot requested a review from daedalus November 27, 2023 20:02

sourcery-ai bot commented Nov 27, 2023

View reviewed changes

sourcery-ai bot force-pushed the sourcery/master branch from d0fbcdc to 0b15853 Compare November 27, 2023 20:27

daedalus merged commit e2fa1fc into master Nov 27, 2023
0 of 2 checks passed

daedalus deleted the sourcery/master branch November 27, 2023 20:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery refactored master branch #2

Sourcery refactored master branch #2

sourcery-ai bot commented Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

sourcery-ai bot Nov 27, 2023

		return [(x[0] * x[1], x[1] - 1) for x in Fx if (x[1]-1) > -1]
		return [(x[0] * x[1], x[1] - 1) for x in Fx if x[1] > 0]

		s = list(map(mul, s[0 : l // 2], s[l // 2 :]))
		s = list(map(mul, s[:l // 2], s[l // 2 :]))

Sourcery refactored master branch #2

Sourcery refactored master branch #2

Conversation

sourcery-ai bot commented Nov 27, 2023

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment

sourcery-ai bot Nov 27, 2023

Choose a reason for hiding this comment