Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci/feat(build,pr-build,seed-build): integrate check runs to report build status #218

Merged
merged 26 commits into from
Jul 16, 2023
Merged

ci/feat(build,pr-build,seed-build): integrate check runs to report build status #218

merged 26 commits into from
Jul 16, 2023

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Jul 14, 2023 •
edited
Loading

Background

Integrate check runs to report build status. Replicate daeuniverse/daed#162

Relevant workflows:

References:

Checklist

Full changelogs

  • ci(pr-build): integrate check runs to report build status
  • ci(pr-build): integrate individual check run per stage
  • ci(seed-build): add build-type input
  • patch(seed-build): use string type for build-type
  • refactor(daily-build): rework workflow logic
  • refactor(build): rework main-build logic

Issue reference

NA

Test Result

https://github.com/daeuniverse/dae/actions/runs/5556529422

image image

New PR Build Structure

image

@piyoki piyoki requested a review from mzz2017 as a code owner July 14, 2023 10:35
@piyoki piyoki changed the title ci(build,pr-build,seed-build): integrate check runs ci/feat(build,pr-build,seed-build): integrate check runs to report build status Jul 14, 2023
dae-prow[bot]
dae-prow bot previously approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki piyoki mentioned this pull request Jul 15, 2023
Open
5 tasks
@piyoki
Copy link
Contributor Author

piyoki commented Jul 15, 2023

There are some issues with secret management as prerequisites for GitHub Check-Run; working on a fix now, hence, this PR should be marked as in a stale state.

@dae-prow
Copy link
Contributor

dae-prow bot commented Jul 15, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@piyoki
Copy link
Contributor Author

piyoki commented Jul 15, 2023 •
edited
Loading

There are some issues with secret management as prerequisites for GitHub Check-Run; working on a fix now, hence, this PR should be marked as in a stale state.

The issue has been fixed in daeuniverse/daed#167; persisted changes in https://github.com/daeuniverse/ci-seed-jobs/blob/master/.github/workflows/dae-post-actions.yml

@mzz2017
Copy link
Contributor

mzz2017 commented Jul 16, 2023

LGTM

@piyoki
Copy link
Contributor Author

piyoki commented Jul 16, 2023

LGTM

Let me test one more scenario before we merge it.

@piyoki
Copy link
Contributor Author

piyoki commented Jul 16, 2023

LGTM

Let me test one more scenario before we merge it.

Issues related to pre-actions seed workflow has been resolved - https://github.com/daeuniverse/dae-1/actions/runs/5565874796

Source: https://github.com/daeuniverse/ci-seed-jobs/blob/master/.github/workflows/pre-actions.yml#L92-L107

@piyoki piyoki merged commit 5e32ffe into main Jul 16, 2023
@piyoki piyoki deleted the check_runs branch July 16, 2023 05:07
@piyoki piyoki mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzz2017 mzz2017 mzz2017 approved these changes

@dae-prow dae-prow[bot] dae-prow[bot] left review comments

Assignees

@piyoki piyoki

Labels
ci feature priority/high tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piyoki @mzz2017