-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for hysteria2 dialer and protocol #533
Conversation
This is a highly anticipated feature support, extremely impressive. It has passed the test on my Linux (kernel 6.9), although there seem to be some warning logs, I'm not sure if it matters: |
是的 在openwrt上运行也出现这种情况 但不影响正常使用 |
@douglarek @xmapst Thank you for your feedback. I plan to address this issue shortly, likely by Wednesday or Thursday. Should you encounter any additional problems during extended use, please don't hesitate to follow up. During my personal usage, I've encountered a few issues:
|
It works on Arch Linux, kernel |
@mnixry For the udp over tcp problem, could you please revert my patch on your local and test it again? |
The current implementation has too high of a delay. The same server is simultaneously configured with tuic (sb implementation) and hy2 (original version). The udp4(DNS) delay results for dae, the former is between 1~4s, while tuic is around 200ms. |
@mzz2017 Reverting the patch did not resolve the issue for me. Further testing indicates that both the official client and the Here's my benchmarking method:
Since curl does not support directly using a socks5 proxy with the HTTP/3 protocol, I am currently unable to provide examples without using dae. Additionally, testing under various network conditions is also needed. |
@mnixry You can use curl -x http://YOUR_PROXY or curl -x socks5://YOUR_PROXY to achieve |
@mzz2017 Sadly, this approach does not work for curl with HTTP/3 protocol. $ ./curl -L4vx socks5://localhost:2080 --http3-only "https://h3.speed.cloudflare.com/__down?bytes=25000000" > /dev/null
* HTTP/3 is not supported over a SOCKS proxy
* Closing connection
curl: (3) HTTP/3 is not supported over a SOCKS proxy I am also wondering if there is any networking tools like curl supports h3 over socks5 proxy. |
@mnixry What about sing-box tun inbound with auto-route? |
@mzz2017 The TUN mode in Sing-box appears to function well with HTTP/3 connections, progressively increasing speeds up to approximately 1 MB/s. Interestingly, even when using UDP-over-TCP proxy solutions, HTTP/3 downloads perform significantly faster than dae (also about 1 MB/s). Could you reproduce these results on your end? Since this appears to be unrelated to the current pull request, we should probably open a new issue for tracking purposes. |
@douglarek Apologies for the delayed response. I'm unable to replicate the issue on my side; it might stem from network jitter or a delay due to initial protocol handshaking. Could you try using tools such as 'dig' from BIND to assess any DNS resolution delays? |
@mnixry I'll look into it as long as i'm free. |
@douglarek @xmapst The issue has been fixed in f2d5302. Could you check out the latest build and confirm whether the warning still persists? |
It's indeed fixed, the warn log has disappeared. This is so awesome. |
太棒了 确实修复了 |
@mnixry I fixed a possibly related problem that caused download speed zeroing. The problem dies away on my local. Could you please try this PR? #539 |
进展如何了? 大概什么时候合并? |
@xmapst I believe there are two things blocking:
However, members of the daeuniverse who determine if this PR will ultimately be merged may hold different opinions. |
好的 感谢告知 |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧪 Since the PR has been fully tested, please consider merging it.
Background
ref: daeuniverse/outbound#9
This PR is currently a draft and needs user feedback to move forward. Users interested in testing this feature are encouraged to use the GitHub Action build.
Checklist
Full Changelogs
Issue Reference
Closes #48
Closes #450
Test Result
This feature should be tested by end user.