Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ipip tunnel as lan/wan interface #615

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

pcmid
Copy link
Contributor

@pcmid pcmid commented Aug 26, 2024

Background

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #614

Test Result

@pcmid pcmid requested a review from a team as a code owner August 26, 2024 13:10
@dae-prow dae-prow bot assigned pcmid Aug 26, 2024
@mzz2017
Copy link
Contributor

mzz2017 commented Aug 27, 2024

你有测试环境吗,请确认是否正常工作?

@pcmid
Copy link
Contributor Author

pcmid commented Aug 27, 2024

@mzz2017 在我的环境中测试是没有问题的

Copy link
Member

@jschwinger233 jschwinger233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In future maybe we can get linkHdrLen based on the the L2 addr, e.g. if ip --br link shows zero mac addr with NOARP, then it's an L2-less device. (We just need to translate ip --br link command into API callings.)

@pcmid
Copy link
Contributor Author

pcmid commented Aug 27, 2024

Thanks!

In future maybe we can get linkHdrLen based on the the L2 addr, e.g. if ip --br link shows zero mac addr with NOARP, then it's an L2-less device. (We just need to translate ip --br link command into API callings.)

We can check the size of LinkAttrs.HardwareAddr, a size of 0 might indicate that it's an L2-less device.

@sumire88 sumire88 changed the title faet: support ipip tunnel as lan/wan interface feat: support ipip tunnel as lan/wan interface Aug 28, 2024
@pcmid
Copy link
Contributor Author

pcmid commented Sep 2, 2024

Are there any other issues that need to be resolved with this PR?

@mzz2017 mzz2017 added the tested label Sep 3, 2024
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit c885661 into daeuniverse:main Sep 3, 2024
26 checks passed
mnixry pushed a commit to mnixry/dae that referenced this pull request Sep 18, 2024
@dae-prow dae-prow bot mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Unable to use an IPIP tunnel as a LAN interface
4 participants