Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add juicity pinned_certchain_sha256 config #219

Merged
merged 4 commits into from
Aug 7, 2023
Merged

feat: add juicity pinned_certchain_sha256 config #219

merged 4 commits into from
Aug 7, 2023

Conversation

bradfordzhang
Copy link
Contributor

Background

add pinned_certchain_sha256 config in web panel.

Checklist

Full changelogs

  • [Implement ...]

Issue reference

Closes #[issue number]

Test Result

1

Signed-off-by: Bradford Zhang <zyc@zyc.name>
@kunish
Copy link
Member

kunish commented Aug 7, 2023

Could you please also add the corresponding translation support under src/i18n, thanks :)

Signed-off-by: Bradford Zhang <zyc@zyc.name>
src/i18n/locales/en.json Outdated Show resolved Hide resolved
src/i18n/locales/zh-Hans.json Outdated Show resolved Hide resolved
bradfordzhang and others added 2 commits August 7, 2023 19:29
Co-authored-by: kunish <17328586+kunish@users.noreply.github.com>
Signed-off-by: Bradford Zhang <zyc@zyc.name>
Co-authored-by: kunish <17328586+kunish@users.noreply.github.com>
Signed-off-by: Bradford Zhang <zyc@zyc.name>
Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution

@kunish kunish merged commit 42cc5ee into daeuniverse:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants