Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configure hysteria2 modal #440

Merged
merged 4 commits into from
Jun 16, 2024
Merged

feat: add configure hysteria2 modal #440

merged 4 commits into from
Jun 16, 2024

Conversation

wanlce
Copy link
Contributor

@wanlce wanlce commented Jun 15, 2024

Background

Ref: https://v2.hysteria.network/docs/developers/URI-Scheme/

image

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

Copy link

@mnixry mnixry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work! This is truly impressive.

port: number
params: Record<string, string | number | boolean>
}) => {
const uri = new URL(`${protocol}://${auth}@${host}:${port}/`)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases, the auth field contains the character @. We should consider implementing an escape mechanism.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your professional advice, fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an issue where my hysteria2 server cannot connect properly if the password contains @, regardless of whether the client escapes it or not. I'm not sure if it's a problem with the implementation on the dae side or if the hysteria2 server's password settings themselves don't support @

server eg:

auth:
 type: password
 password: '@99888'

pinSHA256: values.pinSHA256,
}

return onLinkGeneration(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the dependency chain daed -> wing -> dae by git submodule, we must wait for updates before the backend can function. Perhaps we should mark this PR as a draft, considering that CI builds lack actual backend implementation?

Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wanlce wanlce merged commit ef2b4c5 into daeuniverse:main Jun 16, 2024
12 of 13 checks passed
obfs: '',
obfsPassword: '',
sni: '',
allowInsecure: false,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我突然注意到一个问题,Hy2 的 URI 标准里面要求的是这个值应当为 1 或者 0,但是这个地方处理成了 true 或 false,由于 dae 那边是靠 value == '1' 来判断的,所以这会导致这个选项永远不会被启用。

似乎需要修一下(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants