Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional IDE status messages #4031

Merged
merged 5 commits into from
May 18, 2023

Conversation

keyboardDrummer
Copy link
Member

Add additional IDE status messages, so users aren't wondering what happens between resolution and verification

I've tested the behavior with the current IDE and it still behaves the same, and with an updated IDE it shows the new states.

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer changed the title Add additional IDE status messages, so users aren't wondering what ha… Add additional IDE status messages May 17, 2023
@keyboardDrummer keyboardDrummer enabled auto-merge (squash) May 17, 2023 14:08
MikaelMayer
MikaelMayer previously approved these changes May 17, 2023
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a great addition for users to understand that it takes time to prepare verification. Good idea!

Also, but unrelated, I found that, when verification is onchange, there can be several seconds until resolution (parsing) starts again. I'm wondering what the IDE is doing during all this time.

@keyboardDrummer
Copy link
Member Author

keyboardDrummer commented May 18, 2023

Also, but unrelated, I found that, when verification is onchange, there can be several seconds until resolution (parsing) starts again. I'm wondering what the IDE is doing during all this time.

Some explanation might be found in the description of this PR: #4002

I've noticed that UpdateDocument is not called as quickly as I expected, and the cancellation mechanic on master is not reliable.

@keyboardDrummer keyboardDrummer merged commit 2d31724 into dafny-lang:master May 18, 2023
@keyboardDrummer keyboardDrummer deleted the extraStates branch May 18, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants