-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code for generating error catalog from source code #4047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw a few tiny wording things that could possibly be improved, but this otherwise looks great.
Note that a missing body is different than an empty body, which is just `{ }`. | ||
However, the body must be supplied before the program can be compiled, | ||
even if the method is `ghost`. | ||
Body-less loops in ghost methods are similar to unchecked assumptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, "similar" may be more accurate.
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
Co-authored-by: Aaron Tomb <aarontomb@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you still need to check in the generated error catalog, but otherwise 🚢 .
Yep - first time using the process, so you need to push the approve button again. -- Optimistically presuming the tests will succeed |
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.