Enables output of errorId #4097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-aws
reviewed
May 29, 2023
| @@ -218,7 +218,8 @@ public class ConsoleErrorReporter : BatchErrorReporter { | |||
| errorLine += $" {msg} {tok.TokenToString(Options)}"; | |||
| } | |||
|
|
|||
| if (Options.Verbose && false) { // Need to control tests better before we enable this | |||
| if (Options.Verbose) { // Need to control tests better before we enable this | |||
| errorLine += "\nID: " + errorId; | |||
There was a problem hiding this comment.
I think it's a bit confusing to have just "ID:" on a separate line - less obvious that's it's an error id about the previous line. I think this would be clearer:
formatting1-3.dfy(1,0): Warning: File contains no code (ID: ...)
This would probably be even better, to put the id next to "Warning" or "Error", but may require more plumbing:
formatting1-3.dfy(1,0): Warning (ID: ...): File contains no code
There was a problem hiding this comment.
I'll put it after the message, so the important part of the message is upfront.
It is still only included when --verbose is on, so it won't affect existsing tests, but will take a bit more sedding to tease it out of the message.
Test/dafny0/formatting1.dfy.expect
Outdated
| @@ -23,6 +23,7 @@ module A { | |||
| } | |||
| } | |||
| formatting1-3.dfy(1,0): Warning: File contains no code | |||
| ID: | |||
There was a problem hiding this comment.
I'd say we shouldn't print this at all if there is no error code yet.
| @@ -1,5 +1,6 @@ | |||
| # Reading from symbols.transcript | |||
| bank.dfy(4,25): Warning: constructors no longer need 'this' to be listed in modifies clauses | |||
| ID: none | |||
robin-aws
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds --verbose to parsing and enabling it to emit the errorId and explanation
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.