Feat: Support for --bprint in language server.
#4206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I add this as a way to simplify boogie debugging, especially in cases when VSCode is not consistent with the command-line like in #4205 I did not add any test for that as it's meant for Dafny development only, but I tested it manually. I borrowed the code from the driver.
| @@ -55,6 +56,12 @@ DafnyOptions options | |||
| return translated.SelectMany(t => { | |||
| var (_, boogieProgram) = t; | |||
| var results = engine.GetImplementationTasks(boogieProgram); | |||
| if (engine.Options.PrintFile != null) { | |||
There was a problem hiding this comment.
I would put this in a separate traversal outside of the SelectMany.
if (engine.Options.PrintFile) {
var nmodules = Translator.VerifiableModules(program).Count();
foreach(var boogieProgram in translated) {
..
}
}| @@ -42,6 +42,7 @@ DafnyOptions options | |||
| CancellationToken cancellationToken) { | |||
| var program = document.Program; | |||
| var errorReporter = (DiagnosticErrorReporter)program.Reporter; | |||
| var nmodules = Translator.VerifiableModules(program).Count(); | |||
There was a problem hiding this comment.
Can you give the introduced variables fuller names?
| @@ -52,10 +52,17 @@ DafnyOptions options | |||
|
|
|||
| cancellationToken.ThrowIfCancellationRequested(); | |||
|
|
|||
| if (engine.Options.PrintFile != null) { | |||
| var moduleCount = Translator.VerifiableModules(program).Count(); | |||
| foreach (var t in translated) { | |||
There was a problem hiding this comment.
You can immediately deconstruct the tuple here, so you can better names than t and Item1 and Item2
keyboardDrummer
previously approved these changes
Jul 3, 2023
MikaelMayer
commented
Jul 5, 2023
MikaelMayer
commented
Jul 6, 2023
keyboardDrummer
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add this as a way to simplify boogie debugging, especially in cases when VSCode is not consistent with the command-line like in #4205
I did not add any test for that as it's meant for Dafny development only, but I tested it manually. I borrowed the code from the driver.
Should I still list it as a feature?
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.