Fix: Handling of opaque methods in traits overriding check #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
requested changes
Jul 5, 2023
| } else if (overridingFunction.IsOpaque) { | ||
| // We can't use a bound variable $fuel, because then one of the triggers won't be mentioning this $fuel. | ||
| // Instead, we do the next best thing: use the literal false. | ||
| reveal = new Boogie.IdentifierExpr(f.tok, "false", Boogie.Type.Bool); |
There was a problem hiding this comment.
Can you create a literal expression instead of an identifier expression here? I think this accidentally works but is confusing, since false is an actual value rather than a name for a value, at least in the semantics I understand.
docs/dev/news/4205.fix
Outdated
| @@ -0,0 +1 @@ | |||
| Handling of opaque methods in traits overriding check | |||
There was a problem hiding this comment.
It would be nice to have a longer, more explanatory message here.
There was a problem hiding this comment.
Maybe "Traits with opaque functions can now be extended without errors" or something like that.
MikaelMayer
deleted the
fix-4205-extending-trait-with-an-opaque-function-causes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4205
I added the corresponding test.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.