Skip to content

Commit

Permalink
chore: enable unparam linter (#7174)
Browse files Browse the repository at this point in the history
* chore: fix some doc comments for daqgl to match

Signed-off-by: Justin Chadwell <me@jedevc.com>

* chore: remove some unused parameters

And also enable a linter to catch these in the future. `unparam` seems
to be optimized more heavily to avoid false positives, and is
significantly better at not bringing up weird interface cases that
revive seems to love.

Signed-off-by: Justin Chadwell <me@jedevc.com>

* fixups

Signed-off-by: Justin Chadwell <me@jedevc.com>

---------

Signed-off-by: Justin Chadwell <me@jedevc.com>
  • Loading branch information
jedevc authored May 3, 2024
1 parent 73322fb commit 1bb2243
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions telemetry/batch_processor.go
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ func (bsp *batchSpanProcessor) enqueue(sd trace.ReadOnlySpan) {
if bsp.o.BlockOnQueueFull {
bsp.enqueueBlockOnQueueFull(ctx, sd)
} else {
bsp.enqueueDrop(ctx, sd)
bsp.enqueueDrop(sd)
}
}

Expand All @@ -427,7 +427,7 @@ func (bsp *batchSpanProcessor) enqueueBlockOnQueueFull(ctx context.Context, sd t
}
}

func (bsp *batchSpanProcessor) enqueueDrop(ctx context.Context, sd trace.ReadOnlySpan) bool {
func (bsp *batchSpanProcessor) enqueueDrop(sd trace.ReadOnlySpan) bool {
if !sd.SpanContext().IsSampled() {
return false
}
Expand Down

0 comments on commit 1bb2243

Please sign in to comment.