Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customOrder and disableOptimalOrderHeuristic #263

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

futpib
Copy link
Contributor

@futpib futpib commented Mar 29, 2019

This allows users to customize ordering algorithm. May help address #189, #201 and other

@FelixSchwarzmeier
Copy link

@lutzroeder could this PR please be merged for the next release? Being able to customize the order is a highly requested feature for my project.

@dlangerenken
Copy link

@lutzroeder any updates?

@JoshuaeKaiser
Copy link

Same here, quite an important update.

@apdsm
Copy link

apdsm commented May 14, 2021

Would love if this could get merged!

@Rishav159
Copy link

@lutzroeder Any update on this? This is an important feature for my project.

@TEJATJ
Copy link

TEJATJ commented Oct 4, 2021

Yes this is a good and a needed feature. For dynamic graph-building/flow-creations an option like this would help minimise the frequent ordering of nodes.

@SaiSumanthLokinindi
Copy link

Now as the repo is being maintained, @rustedgrail can we expect this PR to be merged?

@rustedgrail
Copy link
Collaborator

I'll take a look at the branch soon, but at a cursory glance, it looks fine.

@futpib
Copy link
Contributor Author

futpib commented Jun 30, 2023

@rustedgrail rustedgrail merged commit 26cc748 into dagrejs:master Mar 6, 2024
@rustedgrail
Copy link
Collaborator

Thank you for your help and for our patience

@judehunter
Copy link

Hi, this looks great. Could we get some guidance on how to use this to achieve some common use cases, please? @rustedgrail @futpib

@dongtc
Copy link

dongtc commented Apr 28, 2024

Have a doubt,seems it doesn't merged into master ? https://github.com/dagrejs/dagre/blob/master/lib/layout.js#L29

rustedgrail added a commit that referenced this pull request Jun 28, 2024
Add `customOrder` and `disableOptimalOrderHeuristic` - fix #263 merge issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.