Switch dagster_webserver and dagster_gcp_pyspark to hyphens #18902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
johannkm
force-pushed
the
johann/12-26-Change_dagster_webserver_to_dagster-webserver
branch
from
71e9ba2 to
b8afaed
Compare
johannkm
force-pushed
the
johann/12-26-Change_dagster_webserver_to_dagster-webserver
branch
from
b8afaed to
4f670d7
Compare
johannkm
changed the title
jmsanders
approved these changes
Dec 27, 2023
|
Going to land this to get the build green. It looks to me like we'll be ok publishing these packages but there could be an issue with release next week. I'll give @smackesey a heads up since he's running it |
johannkm
deleted the
johann/12-26-Change_dagster_webserver_to_dagster-webserver
branch
johannkm
added a commit
that referenced
this pull request
Dec 27, 2023
Open questions: - ~~why did tests start failing this weekend? (best guess is setuptools 69.03 on Dec 23rd)~~ - ~~why does this fix the failures?~~ - would this be a breaking change? I'm hopeful that it's not, because the package is already published as dagster-webserver https://pypi.org/project/dagster-webserver/ Edit: the first two are answered by pypa/setuptools#2522 (comment): setuptools change how they handle hyphens vs underscores This makes the two required changes to get the build green (these two are special because of the underscore packages, they're the ones that are relied on in tests). In general we should make it a pattern to make package names use hyphens and match their directory name to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open questions:
why did tests start failing this weekend? (best guess is setuptools 69.03 on Dec 23rd)why does this fix the failures?Edit: the first two are answered by pypa/setuptools#2522 (comment): setuptools change how they handle hyphens vs underscores
This makes the two required changes to get the build green (these two are special because of the underscore packages, they're the ones that are relied on in tests). In general we should make it a pattern to make package names use hyphens and match their directory name to avoid confusion.