Fix pickling of frozenlist #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, this looks great. Thanks once again! Will merge once buildkite comes back green |
Like frozendict, implement __reduce__ and __setstate__ to handle pickling. Otherwise, __setstate__ will be called to restore the frozenlist, causing a RuntimeError because frozenlist is not mutable. Closes dagster-io#2719
kinghuang
force-pushed
the
2719-frozenlist-unpickle
branch
from
6d1980f to
742862f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
__reduce__and__setstate__on frozenlist so that it can be unpickled. Otherwise,__setitem__will be called to restore the frozenlist, causing a RuntimeError because frozenlist is not mutable.Also add a couple of simple tests for pickling
frozenlistandfrozendict.Fixes #2719.