Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SafeHANDLE != operator should make parameters nullable #459

Closed
GF-Huang opened this issue Apr 24, 2024 · 3 comments
Closed

SafeHANDLE != operator should make parameters nullable #459

GF-Huang opened this issue Apr 24, 2024 · 3 comments

Comments

@GF-Huang
Copy link

Describe the bug and how to reproduce
It's not a bug.

image

Expected behavior
No warning(CS8604).
@dahall
Copy link
Owner

dahall commented Apr 27, 2024

Fixed in 4.0.1

@dahall dahall closed this as completed Apr 27, 2024
dahall added a commit that referenced this issue Apr 27, 2024
@dahall
Added null handlers to SafeHANDLE equality methods. (#459)
dc62d8c
@GF-Huang
Copy link
Author

GF-Huang commented May 4, 2024

The h1 seems also need to nullable. 😄

image

@dahall
Copy link
Owner

dahall commented May 5, 2024

Corrected this and the == operator so null SafeHANDLEs are covered in 4.0.2

dahall added a commit that referenced this issue May 5, 2024
@dahall
Added nullability to SafeHANDLE operators (#459)
7919216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GF-Huang @dahall