fix PROPVARIANT at 64-bit, Clearing string Vectors + UT #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLOBbecomes a leading value type forPROPVARIANT_IMMUTABLEas it takes another[StructLayout.Pack]at 64-bit platform thanks to the pointer in the structure (BLOBis 12B,PROPVARIANTis 24B size at 64-bit OS)[StructLayout.Pack]removed atPROPVARIANTas it makes no sense withLayoutKind.Explicit[StructLayout.Size]removed at both structures to allow this extensionClearing
BSTRVector - superfluous indirection fixed (bug revealed by UT after 64-bit fix)Clearing
LPSTRVector - uncommented & fixed (it was commented probably due to the same bug, in the way that causes memory leak)IPropSetStorageTestenhanced to read/write multiple properties (it reveals the 64-bit issue)