Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] new implementation with useMutableSource #43

Closed
wants to merge 50 commits into from
Closed

[v2] new implementation with useMutableSource #43

wants to merge 50 commits into from

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Mar 12, 2020

  • separate proxy-compare as a dependency done in v1.5
  • new implementation with useMutableSource in the RFC
  • in TypeScript done in v1.5
  • mode=0 by default (breaking change in behavior) done in v1.5

Check list:

  • implementation
  • readme
  • docs
  • better to use batchedUpdates?

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 12, 2020

There's still something I would like to investigate.
Currently, it's failing "check 3" in https://github.com/dai-shi/will-this-react-global-state-work-in-concurrent-mode, because render interruptions take more time (avg 800ms > 300ms).

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 12, 2020

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 12, 2020

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 16, 2020

@dai-shi
Copy link
Owner Author

dai-shi commented Mar 24, 2020

@dai-shi
Copy link
Owner Author

dai-shi commented May 13, 2020

One of the e2e tests failed with a weird behavior in 07_todolist. Downgrading react experimental fixes it... 0.0.0-experimental-d7382b6c4
Let's wait for upstream to fix it...

@dai-shi
Copy link
Owner Author

dai-shi commented Aug 4, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d3c2127:

Sandbox Source
React Configuration
React Typescript Configuration

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 26, 2020

Let me close this for now because:

  • uMS is not likely to be landed soon.
  • since v1.5, react-tracked depends on use-context-selector and not much is required to support uMS in this repo.
  • we hope some better primitive hooks for react state instead of uMS.

@dai-shi dai-shi closed this Dec 26, 2020
@dai-shi dai-shi deleted the v2 branch December 26, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant