Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update react beta #671

Closed
wants to merge 1 commit into from
Closed

update react beta #671

wants to merge 1 commit into from

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Apr 25, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Apr 25, 2024 11:06pm

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi
Copy link
Owner Author

dai-shi commented Apr 25, 2024

All reds.
Is this related to what @Tobbe said in the react repo?

@himself65
Copy link
Contributor

I feel like there is a module resolution issue somewhere var React = require('react'); is undefined

@himself65
Copy link
Contributor

Ok, I debug and __SERVER_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE is in React but __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE is not, so at that moment, it returns react server code

@dai-shi
Copy link
Owner Author

dai-shi commented Apr 26, 2024

Hm? Is there anything we can do then?

@himself65
Copy link
Contributor

I'm bisecting to see which commit caused this

@himself65
Copy link
Contributor

himself65 commented Apr 26, 2024 •
edited
Loading

@himself65
Copy link
Contributor

OK, I made some changes in the React source code, and it works well. Not sure if this is an upstream issue... But I will open a draft to react repo

@himself65 himself65 mentioned this pull request Apr 26, 2024
Merged
@lazarv
Copy link

lazarv commented Apr 27, 2024

Hi @dai-shi! I've found this issue and related PR at React while fixing and patching up my framework.
My workaround was to register a node.js loader, where I change react/jsx-dev-runtime to react/jsx-runtime with react-server conditions. But I'm still working on resolving every breaking change React introduced since I created my initial version of my own framework. I was almost finished with the next version and the docs when I tried to upgrade to latest experimental React. Congrats for the release and keep up!

@himself65
Copy link
Contributor

Waiting for facebook/react#28921 a new beta release

@eps1lon
Copy link

eps1lon commented Apr 27, 2024

New Beta releases are automatically published every day around 4:15pm UTC

@himself65 himself65 mentioned this pull request May 1, 2024
Merged
@dai-shi dai-shi closed this in #688 May 1, 2024
dai-shi added a commit that referenced this pull request May 1, 2024
@himself65 @dai-shi
chore: bump to react@19-beta (#688)
c0eb2c9 
Closes: #671
Upstream: facebook/react#28921

---------

Co-authored-by: daishi <daishi@axlight.com>
@dai-shi dai-shi deleted the update-react-beta branch May 1, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dai-shi @himself65 @lazarv @eps1lon