fix: waku build will bundle browser files in server side #900
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
| @@ -374,6 +380,9 @@ const buildClientBundle = async ( | |||
| rscTransformPlugin({ isClient: true, isBuild: true, serverEntryFiles }), | |||
| ...deployPlugins(config), | |||
| ], | |||
| resolve: { | |||
| conditions: ['import', 'module', 'default', 'browser', 'production'], | |||
There was a problem hiding this comment.
Is it intentional to have 'default' before 'browser'?
himself65
force-pushed
the
himself65/20240925/condition
branch
from
f7ef259
to
3c2e0fa
Compare
| @@ -112,6 +112,9 @@ const createMainViteServer = ( | |||
| rscHmrPlugin(), | |||
| fsRouterTypegenPlugin(config), | |||
| ], | |||
| resolve: { | |||
| conditions: ['import', 'module', 'default'], | |||
There was a problem hiding this comment.
MainViteServer is used to bundle for browsers.
It should be in ssr.resolve.conditions.
Do we need to change RscViteServer?
Now I wonder if build.ts change is correct.
There was a problem hiding this comment.
I tested, ssrLoadModule won't use browser condition by default
There was a problem hiding this comment.
So, what's the original problem?
This MainViteServer it to for browsers, so browser condition should be appropriate.
Default options for vite includes
browser, whch might cause some bundler issueRef: https://v2.vitejs.dev/config/#resolve-conditions
Downstream: run-llama/LlamaIndexTS#1256