Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run tsc on examples #968

Merged
merged 1 commit into from
Oct 18, 2024
Merged

chore: run tsc on examples #968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/03_demo/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"skipLibCheck": true,
"noUncheckedIndexedAccess": true,
"exactOptionalPropertyTypes": true,
"types": ["react/experimental"],
"types": ["node", "react/experimental"],
"jsx": "react-jsx"
}
}
1 change: 1 addition & 0 deletions examples/04_cssmodules/src/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
declare module '*.module.css';
2 changes: 1 addition & 1 deletion examples/43_weave-render/src/components/BarLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const BarLayout = ({ children }: { children: ReactNode }) => {
</li>
<li>
<Link
to="/nested/bar"
to={'/nested/bar' as never}
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tylersayshi does it look okay??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what is the goal of this?

pending={<Pending isPending />}
notPending={<Pending isPending={false} />}
>
Expand Down
2 changes: 1 addition & 1 deletion examples/43_weave-render/src/components/HomeLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const HomeLayout = ({ children }: { children: ReactNode }) => {
</li>
<li>
<Link
to="/nested/bar"
to={'/nested/bar' as never}
pending={<Pending isPending />}
notPending={<Pending isPending={false} />}
>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"dev": "pnpm -r --filter='./packages/*' run dev",
"compile": "pnpm -r --filter='./packages/*' run compile",
"csb-install-FIXME": "pnpm install --no-frozen-lockfile",
"test": "prettier -c . && eslint . && tsc -b && pnpm run --filter waku test",
"test": "prettier -c . && eslint . && tsc -b && tsc -b --noEmit `find examples -mindepth 1 -maxdepth 1 -type d ! -name '*_js'` && pnpm run --filter waku test",
"e2e": "playwright test",
"examples:dev": "(cd ./examples/${NAME} && pnpm run dev)",
"examples:build": "(cd ./examples/${NAME} && pnpm run build)",
Expand Down
Loading