refactor: move from ncc to tsup for create-waku #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
himself65
reviewed
Oct 18, 2024
packages/create-waku/package.json
Outdated
| "compile": "rm -rf template dist *.tsbuildinfo && pnpm run template && pnpm run build", | ||
| "template": "cp -r ../../examples template && rm -rf template/*/dist && rm -rf template/*/node_modules && (for d in template/*; do mv $d/.gitignore $d/gitignore || true; done)", | ||
| "build": "ncc build ./src/index.ts -o ./dist/ --minify --no-cache --no-source-map-register" | ||
| "build": "tsup ./src/index.ts --minify --format esm" |
There was a problem hiding this comment.
sure! changed 👍
himself65
approved these changes
Oct 19, 2024
|
Ahh, I should have asked before merging. Do we still need this hack? waku/packages/create-waku/src/index.ts Lines 165 to 167 in cd48920 |
dai-shi
added a commit
that referenced
this pull request
Oct 21, 2024
follow up to this: #974 (comment) --------- Co-authored-by: Tyler <tyler@secondspectrum.com> Co-authored-by: daishi <daishi@axlight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like a bundler is needed for helping to minify the published code and transpile from typescript.
I've had a good personal experience with tsup and I saw @himself65 mention it, so figured I'd make this PR to help :)
Closes #973