Port defadvice to define-advice #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Emacs 30.1, `defadvice` has been marked obsolete, and can lead to byte-compilation errors. Luckily, this is pretty easy to fix: all we need to do is replace `defadvice` with `define-advice`.
|
Thanks for the PR. Hmm, fails for emacs 26.3. Wonder if there is something different with the evaluation time of the advice body between the two macros. Perhaps |
|
It looks like it fails for 26.1 and 27.2 as well, which is odd. I've added the |
|
Seems all versions pass checks so merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Emacs 30.1,
defadvicehas been marked obsolete, and can lead to byte-compilation errors. Luckily, this is pretty easy to fix: all we need to do is replacedefadvicewithdefine-advice.