Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stack overflow. Caused by: Could not compile curve25519-dalek #261

Closed
SemElVik opened this issue Jun 16, 2019 · 16 comments
Closed

stack overflow. Caused by: Could not compile curve25519-dalek #261

SemElVik opened this issue Jun 16, 2019 · 16 comments

Comments

@SemElVik
Copy link

#252 (comment)

@hdevalence
Copy link
Contributor

Can you post any information about how to reproduce this problem?

@SemElVik
Copy link
Author

SemElVik commented Jun 22, 2019

I did not quite understand your question, what do you mean by the word "reproduce"?
how can you get this error?
...
This error occurred not only with me.
there is another person with the same problem.

This assembly happens every other time. 5 times not well -1 times good.
conditionally so.
From the root, it did not work out at all.

@hdevalence
Copy link
Contributor

Yes, I mean what steps you do to get this error.

Does it happen every time you do those steps, or only sometimes?

How can I test the error?

@SemElVik
Copy link
Author

3 builds are working at the moment and I can not recompile them.
there is another person with the same error. I will clarify with him.
if nothing happens, I will try to get this error myself personally.., and then I will give a reproduction

@gaia
Copy link

gaia commented Jul 8, 2019

unconfirmed, but I was only able to reproduce the issue (in building tmkms) when I installed rust via apt install cargo. when I used curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh tmkms compiled fine.

@tarcieri
Copy link
Contributor

tarcieri commented Jul 9, 2019

@gaia interesting. I'll note that I build tmkms using Rust as installed from RPMs, and have never experienced this issue.

Perhaps the Debian/Ubuntu packages are doing something odd.

@hdevalence
Copy link
Contributor

@gaia What are the respective versions of rust installed by each method?

@gaia
Copy link

gaia commented Jul 9, 2019

@hdevalence
via cargo: rustc 1.32.0
via sh.rustup.rs: rustc 1.36.0

@warner
Copy link

warner commented Jul 23, 2019

I just spun up a couple of VMs with various debian/ubuntu versions, and cargo build --release worked each time:

  • ubuntu/bionic (rustc-1.35.0)
  • ubuntu/cosmic (rustc-1.34.1)
  • ubuntu/disco (rustc-1.35.something)
  • ubuntu/eoan (rustc-1.35.something)
  • debian/buster (rustc-1.34.2)

I didn't encounter a distribution which includes rustc-1.32.0.

@gaia what version of the OS are you using? And what architecture (amd64)?

FWIW, rustup run 1.32.0 cargo test worked for me, on debian/stretch, with the toolchain from sh.rustup.rs. So it seems like more than just the rustc version.

@gaia
Copy link

gaia commented Jul 23, 2019

@warner Ubuntu 18.04.2 amd64

@warner
Copy link

warner commented Jul 23, 2019

Hm, on a fresh ubuntu-18.04.2 system ("bionic") I'm getting rust 1.35.0, but that's including some updates repo.

@gaia what do dpkg -s cargo |grep Version and dpkg -s rustc |grep Version report?

@SemElVik
Copy link
Author

ok.
cos@cos:~$ dpkg -s rustc |grep Version Version: 1.32.0+dfsg1+llvm-1ubuntu1~18.04.1
cos@cos:~$ dpkg -s cargo |grep Version Version: 0.33.0-1ubuntu1~18.04.1

perhaps on that moment compilation there was no version 1.35 yet.
not sure when it refreshed

@warner
Copy link

warner commented Jul 24, 2019

for reference, http://security.ubuntu.com/ubuntu/pool/universe/r/rustc/ has the older .deb packages, including the 1.32.0+dfsg1+llvm-1... version that seems to be on your machine. It appears to be non-trivial to downgrade an updated bionic system to use that version, though, at least when I tried to dpkg install that one package, I got errors about libstd-rust-dev and libc too.

@gaia
Copy link

gaia commented Jul 24, 2019

dpkg -s cargo |grep Version

I already have the updated cargo and rustc on my machine now. at that time it was as mentioned in #261 (comment)

@warner
Copy link

warner commented Jul 26, 2019

I've got users who hit this problem too.. if they can reproduce it, what information would you want from them? Or should I just recommend they upgrade to rustc > 1.32.0?

@hdevalence
Copy link
Contributor

I'm not sure what the problem is, so I'm not sure what information would be the most useful. I think that compilation should not trigger a stack overflow. Since it apparently does, in some cases, there's a question of what the cause is: either a) in some part of rustc or b) in the build.rs script, which are the two places that execute code during compilation. In case a) I guess there's nothing to do but to update rustc; in case b) I think the cleanest solution is #217 which hopefully removes the problem entirely?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants