Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem by dynamically adding tests at runtime is these can be missed silently if the dyn generation fails - google doesn't add / modify / remove them much in any case so can just re-generate & check em in when needed 🤷♀️
wycheproofs-ed25519-dalek
is excluded from workspace--all-features
so it doesn't barf with theed25519-dalek/legacy_compatibility
-It still gets tested by default features OK via workspace
Notes
Testing whole workspace with
--all-features
enables every feature fromed25519-dalek
dependency despitewycheproofs-ed25519-dalek
not explicitly including it due to how the resolver works within workspace.Namedly
ed25519-dalek/legacy_compatibility
causes barf at wycheproof expanded generated.rs tc 63 and 85 failsrepro @ 4af5275
workspace_root $ cargo test --target x86_64-unknown-linux-gnu --features legacy_compatibility
So tests worked I guess :]
Follow-Ups
I will also send another PR to turn the VALIDATION_CRITERIA into static tests directly from C2SP/CCTV/ed25519/vectors.json and some sort of checksumming / commit following thing perhaps to follow modulo easily