Make use rand::... gated on cfg(feature = "rand")
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is no longer actively breaking our no_std build, but I think it's still technically a minor bug, and further case of issue dalek-cryptography#108
Closed
Xanewok
approved these changes
Aug 12, 2020
isislovecruft
approved these changes
Sep 21, 2020
There was a problem hiding this comment.
Hi @garbageslam. Thanks for the PR.
I'm happy to merge but this means that the SecretKey::generate function below won't work unless the "rand" feature is present, so it'll need to be feature gated as well. Additionally, I think the "rand" feature should be on by default, otherwise this breaks some backwards compatibility.
|
There's also a few other places where |
isislovecruft
added a commit
to isislovecruft/ed25519-dalek
that referenced
this pull request
Sep 21, 2020
isislovecruft
added a commit
to isislovecruft/ed25519-dalek
that referenced
this pull request
Sep 21, 2020
huitseeker
pushed a commit
to huitseeker/ed25519-dalek
that referenced
this pull request
Nov 3, 2020
huitseeker
pushed a commit
to huitseeker/ed25519-dalek
that referenced
this pull request
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer actively breaking our no_std build, but I think
it's still technically a minor bug, and further case of issue #108
This was #110
but that PR was very old and there were additional issues then which are moot now